archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-10 17:01:24 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

SPUThread.cpp: remove "__attribute__((always_inline))"

Browse source 
cmp_rdata and mov_rdata are using __attribute__((always_inline)),
without inline, that is not supported on current g++ (see RPCS3#1546).

Moreover __attribute__((always_inline)) is a noop if used without inline so
just remove it.

A proper fix is to move the 2 functions in an header file as static
(with FORCE_INLINE) so it can be correctly inlined by the compiler.
This commit is contained in:
Timothy Redaelli 2021-03-03 20:50:14 +01:00 • committed by Ivan
parent 8b8120cfb7
commit fa5a2b6a85
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
rpcs3/Emu/Cell/SPUThread.cpp
View file

@ -133,8 +133,6 @@ static FORCE_INLINE bool cmp_rdata_avx(const __m256i* lhs, const __m256i* rhs)
#ifdef _MSC_VER #ifdef _MSC_VER
__forceinline __forceinline
#else
__attribute__((always_inline))
#endif #endif
extern bool cmp_rdata(const spu_rdata_t& _lhs, const spu_rdata_t& _rhs) extern bool cmp_rdata(const spu_rdata_t& _lhs, const spu_rdata_t& _rhs)
{ {
@ -189,8 +187,6 @@ static FORCE_INLINE void mov_rdata_avx(__m256i* dst, const __m256i* src)
#ifdef _MSC_VER #ifdef _MSC_VER
__forceinline __forceinline
#else
__attribute__((always_inline))
#endif #endif
extern void mov_rdata(spu_rdata_t& _dst, const spu_rdata_t& _src) extern void mov_rdata(spu_rdata_t& _dst, const spu_rdata_t& _src)
{ {