From fa5a2b6a8523b25152564ac641c1f7cd873a5e5a Mon Sep 17 00:00:00 2001 From: Timothy Redaelli Date: Wed, 3 Mar 2021 20:50:14 +0100 Subject: [PATCH] SPUThread.cpp: remove "__attribute__((always_inline))" cmp_rdata and mov_rdata are using __attribute__((always_inline)), without inline, that is not supported on current g++ (see RPCS3#1546). Moreover __attribute__((always_inline)) is a noop if used without inline so just remove it. A proper fix is to move the 2 functions in an header file as static (with FORCE_INLINE) so it can be correctly inlined by the compiler. --- rpcs3/Emu/Cell/SPUThread.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/rpcs3/Emu/Cell/SPUThread.cpp b/rpcs3/Emu/Cell/SPUThread.cpp index c35db82a20..d1b35c8f75 100644 --- a/rpcs3/Emu/Cell/SPUThread.cpp +++ b/rpcs3/Emu/Cell/SPUThread.cpp @@ -133,8 +133,6 @@ static FORCE_INLINE bool cmp_rdata_avx(const __m256i* lhs, const __m256i* rhs) #ifdef _MSC_VER __forceinline -#else -__attribute__((always_inline)) #endif extern bool cmp_rdata(const spu_rdata_t& _lhs, const spu_rdata_t& _rhs) { @@ -189,8 +187,6 @@ static FORCE_INLINE void mov_rdata_avx(__m256i* dst, const __m256i* src) #ifdef _MSC_VER __forceinline -#else -__attribute__((always_inline)) #endif extern void mov_rdata(spu_rdata_t& _dst, const spu_rdata_t& _src) {