fix Clang warnings

This commit is contained in:
oltolm 2023-11-28 21:25:49 +01:00 committed by Megamouse
parent 1c78584f41
commit fdcb481f07
3 changed files with 6 additions and 6 deletions

View file

@ -31,6 +31,8 @@ std::string wchar_to_utf8(std::wstring_view src)
#endif #endif
} }
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
std::string utf16_to_utf8(std::u16string_view src) std::string utf16_to_utf8(std::u16string_view src)
{ {
std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> converter{}; std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> converter{};
@ -42,6 +44,7 @@ std::u16string utf8_to_utf16(std::string_view src)
std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> converter{}; std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> converter{};
return converter.from_bytes(src.data()); return converter.from_bytes(src.data());
} }
#pragma GCC diagnostic pop
std::wstring utf8_to_wchar(std::string_view src) std::wstring utf8_to_wchar(std::string_view src)
{ {

View file

@ -120,7 +120,7 @@ std::vector<version_entry> get_savestate_versioning_data(fs::file&& file, std::s
ar.breathe(true); ar.breathe(true);
std::vector<version_entry> ver_data = ar.pop<std::vector<version_entry>>(); std::vector<version_entry> ver_data = ar.pop<std::vector<version_entry>>();
return std::move(ver_data); return ver_data;
} }
bool is_savestate_version_compatible(const std::vector<version_entry>& data, bool is_boot_check) bool is_savestate_version_compatible(const std::vector<version_entry>& data, bool is_boot_check)
@ -183,10 +183,10 @@ std::string get_savestate_file(std::string_view title_id, std::string_view boot_
if (std::string path_compressed = path + ".gz"; fs::is_file(path_compressed)) if (std::string path_compressed = path + ".gz"; fs::is_file(path_compressed))
{ {
return std::move(path_compressed); return path_compressed;
} }
return std::move(path); return path;
} }
bool is_savestate_compatible(fs::file&& file, std::string_view filepath) bool is_savestate_compatible(fs::file&& file, std::string_view filepath)

View file

@ -658,9 +658,6 @@ void compressed_serialization_file_handler::file_writer_thread_op()
{ {
compressed_stream_data& stream = *m_stream; compressed_stream_data& stream = *m_stream;
// Data recheck after an abort request is detected so there will not be any missed data
bool rechecked = false;
while (true) while (true)
{ {
stream.m_queued_data_to_write.wait(); stream.m_queued_data_to_write.wait();