archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-05 14:31:24 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

vm: Minor optimization for memory serialization

Browse source
This commit is contained in:
Eladash 2023-11-27 15:33:04 +02:00 • committed by Elad Ashkenazi
parent ac19a50f5f
commit f8ca5cdf56
2 changed files with 21 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

25
rpcs3/Emu/Memory/vm.cpp
View file

@ -1617,14 +1617,14 @@ namespace vm
const v128 _5 = _1 | _2; const v128 _5 = _1 | _2;
const v128 _6 = _3 | _4; const v128 _6 = _3 | _4;
const v128 _7 = _5 | _6; const v128 _7 = _5 | _6;
return _7 == v128{}; return gv_testz(_7);
} }
static void serialize_memory_bytes(utils::serial& ar, u8* ptr, usz size) static void serialize_memory_bytes(utils::serial& ar, u8* ptr, usz size)
{ {
ensure((size % 4096) == 0); ensure((size % 4096) == 0);
for (; size; ptr += 128 * 8) for (usz iter_count = 0; size; iter_count++, ptr += 128 * 8)
{ {
const usz process_size = std::min<usz>(size, 128 * 8); const usz process_size = std::min<usz>(size, 128 * 8);
size -= process_size; size -= process_size;
@ -1633,12 +1633,20 @@ namespace vm
if (ar.is_writing()) if (ar.is_writing())
{ {
for (usz i = 0; i < process_size; i += 128) for (usz i = 0; i < process_size; i += 128 * 2)
{ {
if (!check_cache_line_zero(ptr + i)) const u64 sample64_1 = read_from_ptr<u64>(ptr, i);
const u64 sample64_2 = read_from_ptr<u64>(ptr, i + 128);
// Speed up testing in scenarios where it is likely non-zero data
if (sample64_1 && sample64_2)
{ {
bitmap |= 1u << (i / 128); bitmap |= 3u << (i / 128);
continue;
} }
bitmap |= (check_cache_line_zero(ptr + i + 0) ? 0 : 1) << (i / 128);
bitmap |= (check_cache_line_zero(ptr + i + 128) ? 0 : 2) << (i / 128);
} }
} }
@ -1665,8 +1673,13 @@ namespace vm
i += block_count * 128; i += block_count * 128;
} }
ar.breathe(); if (iter_count % 256 == 0)
{
ar.breathe();
}
} }
ar.breathe();
} }
void block_t::save(utils::serial& ar, std::map<utils::shm*, usz>& shared) void block_t::save(utils::serial& ar, std::map<utils::shm*, usz>& shared)

4
rpcs3/util/serialization.hpp
View file

@ -453,9 +453,9 @@ namespace utils
// Execute only if past memory is known to not going be reused // Execute only if past memory is known to not going be reused
void breathe(bool forced = false) void breathe(bool forced = false)
{ {
if (!forced && (!m_file_handler || (data.size() < 0x20'0000 && pos >= data_offset))) if (!forced && (!m_file_handler || (data.size() < 0x100'0000 && pos >= data_offset)))
{ {
// Let's not do anything if less than 32MB // Let's not do anything if less than 16MB
return; return;
} }