archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-11 09:18:40 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use move semantics with several shared pointers in vfs_dialog, they need not be copied

Browse source
This commit is contained in:
Silent 2019-07-21 09:44:03 +02:00 • committed by Megamouse
parent 78ecacabcb
commit f5f0a5aa19
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rpcs3/rpcs3qt/vfs_dialog.cpp
View file

@ -5,7 +5,7 @@
inline std::string sstr(const QString& _in) { return _in.toStdString(); } inline std::string sstr(const QString& _in) { return _in.toStdString(); }
vfs_dialog::vfs_dialog(std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent) vfs_dialog::vfs_dialog(std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent)
: QDialog(parent), m_gui_settings(guiSettings), m_emu_settings(emuSettings) : QDialog(parent), m_gui_settings(std::move(guiSettings)), m_emu_settings(std::move(emuSettings))
{ {
QTabWidget* tabs = new QTabWidget(); QTabWidget* tabs = new QTabWidget();
tabs->setUsesScrollButtons(false); tabs->setUsesScrollButtons(false);

4
rpcs3/rpcs3qt/vfs_dialog_tab.cpp
View file

@ -5,8 +5,8 @@
inline std::string sstr(const QString& _in) { return _in.toStdString(); } inline std::string sstr(const QString& _in) { return _in.toStdString(); }
vfs_dialog_tab::vfs_dialog_tab(const vfs_settings_info& settingsInfo, std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent) vfs_dialog_tab::vfs_dialog_tab(vfs_settings_info settingsInfo, std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent)
: QWidget(parent), m_info(settingsInfo), m_gui_settings(guiSettings), m_emu_settings(emuSettings) : QWidget(parent), m_info(std::move(settingsInfo)), m_gui_settings(std::move(guiSettings)), m_emu_settings(std::move(emuSettings))
{ {
m_dirList = new QListWidget(this); m_dirList = new QListWidget(this);

2
rpcs3/rpcs3qt/vfs_dialog_tab.h
View file

@ -23,7 +23,7 @@ class vfs_dialog_tab : public QWidget
Q_OBJECT Q_OBJECT
public: public:
explicit vfs_dialog_tab(const vfs_settings_info& info, std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent = nullptr); explicit vfs_dialog_tab(vfs_settings_info info, std::shared_ptr<gui_settings> guiSettings, std::shared_ptr<emu_settings> emuSettings, QWidget* parent = nullptr);
void SetSettings(); void SetSettings();
void AddNewDirectory(); void AddNewDirectory();