archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-06 06:51:26 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

patch_manager: Always move All titles to the top

Browse source
This commit is contained in:
Megamouse 2020-06-27 15:26:14 +02:00
parent 3a17eefde7
commit e5bb5f02e0
2 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

24
rpcs3/rpcs3qt/patch_manager_dialog.cpp
View file

@ -181,11 +181,12 @@ void patch_manager_dialog::populate_tree()
} }
const QString q_title = QString::fromStdString(title); const QString q_title = QString::fromStdString(title);
const QString visible_title = title == patch_key::all ? tr_all_titles : q_title;
QTreeWidgetItem* title_level_item = nullptr; QTreeWidgetItem* title_level_item = nullptr;
// Find top level item for this title // Find top level item for this title
if (const auto list = ui->patch_tree->findItems(q_title, Qt::MatchFlag::MatchExactly, 0); list.size() > 0) if (const auto list = ui->patch_tree->findItems(visible_title, Qt::MatchFlag::MatchExactly, 0); list.size() > 0)
{ {
title_level_item = list[0]; title_level_item = list[0];
} }
@ -194,14 +195,14 @@ void patch_manager_dialog::populate_tree()
if (!title_level_item) if (!title_level_item)
{ {
title_level_item = new QTreeWidgetItem(); title_level_item = new QTreeWidgetItem();
title_level_item->setText(0, title == patch_key::all ? tr_all_titles : q_title); title_level_item->setText(0, visible_title);
title_level_item->setData(0, title_role, q_title); title_level_item->setData(0, title_role, q_title);
title_level_item->setData(0, node_level_role, node_level::title_level); title_level_item->setData(0, node_level_role, node_level::title_level);
title_level_item->setData(0, persistance_role, true); title_level_item->setData(0, persistance_role, true);
ui->patch_tree->addTopLevelItem(title_level_item); ui->patch_tree->addTopLevelItem(title_level_item);
} }
assert(title_level_item); ASSERT(title_level_item);
for (const auto& [serial, app_versions] : serials) for (const auto& [serial, app_versions] : serials)
{ {
@ -235,7 +236,7 @@ void patch_manager_dialog::populate_tree()
title_level_item->addChild(serial_level_item); title_level_item->addChild(serial_level_item);
} }
assert(serial_level_item); ASSERT(serial_level_item);
// Add a checkable leaf item for this patch // Add a checkable leaf item for this patch
const QString q_description = QString::fromStdString(description); const QString q_description = QString::fromStdString(description);
@ -289,6 +290,21 @@ void patch_manager_dialog::populate_tree()
} }
gui::utils::sort_tree(ui->patch_tree, Qt::SortOrder::AscendingOrder, true); gui::utils::sort_tree(ui->patch_tree, Qt::SortOrder::AscendingOrder, true);
// Move "All titles" to the top
// NOTE: "All serials" is only allowed as the only node in "All titles", so there is no need to move it up
// NOTE: "All versions" will be above valid numerical versions through sorting anyway
if (const auto all_title_items = ui->patch_tree->findItems(tr_all_titles, Qt::MatchExactly); all_title_items.size() > 0)
{
auto item = all_title_items[0];
ASSERT(item && all_title_items.size() == 1);
if (const int index = ui->patch_tree->indexOfTopLevelItem(item); index >= 0)
{
ui->patch_tree->takeTopLevelItem(index);
ui->patch_tree->insertTopLevelItem(0, item);
}
}
} }
void patch_manager_dialog::save_config() void patch_manager_dialog::save_config()

2
rpcs3/rpcs3qt/patch_manager_dialog.h
View file

@ -30,7 +30,7 @@ class patch_manager_dialog : public QDialog
QString patch_version; QString patch_version;
}; };
const QString tr_all_titles = tr("All titles"); const QString tr_all_titles = tr("All titles - Warning: These patches will apply globally to all games. Use with caution!");
const QString tr_all_serials = tr("All serials"); const QString tr_all_serials = tr("All serials");
const QString tr_all_versions = tr("All versions"); const QString tr_all_versions = tr("All versions");