From c882f0baf0ac67fe485192f13046e152c9827a32 Mon Sep 17 00:00:00 2001 From: Megamouse Date: Tue, 15 Oct 2024 00:42:41 +0200 Subject: [PATCH] input: fix segfault caused by lockless std::move of stick vector The copy assignment seems to fix this --- rpcs3/Input/keyboard_pad_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpcs3/Input/keyboard_pad_handler.cpp b/rpcs3/Input/keyboard_pad_handler.cpp index 7bb6f80b92..76303debc2 100644 --- a/rpcs3/Input/keyboard_pad_handler.cpp +++ b/rpcs3/Input/keyboard_pad_handler.cpp @@ -1278,6 +1278,6 @@ void keyboard_pad_handler::process() } pad->m_buttons = pad_internal.m_buttons; - pad->m_sticks = std::move(squircled_sticks); + pad->m_sticks = squircled_sticks; // Don't use std::move here. We assign values lockless, so std::move can lead to segfaults. } }