diff --git a/rpcs3/Input/keyboard_pad_handler.cpp b/rpcs3/Input/keyboard_pad_handler.cpp index 2e896ed0cc..f4c19bedf9 100644 --- a/rpcs3/Input/keyboard_pad_handler.cpp +++ b/rpcs3/Input/keyboard_pad_handler.cpp @@ -217,9 +217,11 @@ void keyboard_pad_handler::processKeyEvent(QKeyEvent* event, bool pressed) }; // We need to ignore keys when using rpcs3 keyboard shortcuts + // NOTE: needs to be updated with gs_frame::keyPressEvent switch (event->key()) { case Qt::Key_Escape: + case Qt::Key_F12: break; case Qt::Key_L: case Qt::Key_Return: diff --git a/rpcs3/rpcs3qt/gs_frame.cpp b/rpcs3/rpcs3qt/gs_frame.cpp index 7c1f746b57..9a53547f02 100644 --- a/rpcs3/rpcs3qt/gs_frame.cpp +++ b/rpcs3/rpcs3qt/gs_frame.cpp @@ -116,6 +116,8 @@ void gs_frame::showEvent(QShowEvent *event) void gs_frame::keyPressEvent(QKeyEvent *keyEvent) { + // NOTE: needs to be updated with keyboard_pad_handler::processKeyEvent + switch (keyEvent->key()) { case Qt::Key_L: diff --git a/rpcs3/rpcs3qt/pad_settings_dialog.cpp b/rpcs3/rpcs3qt/pad_settings_dialog.cpp index 94c9681e53..8fbbfb0924 100644 --- a/rpcs3/rpcs3qt/pad_settings_dialog.cpp +++ b/rpcs3/rpcs3qt/pad_settings_dialog.cpp @@ -413,7 +413,7 @@ void pad_settings_dialog::InitButtons() // Use timer to get button input connect(&m_timer_input, &QTimer::timeout, [this, callback, fail_callback]() { - std::vector buttons = + const std::vector buttons = { m_cfg_entries[button_ids::id_pad_l2].key, m_cfg_entries[button_ids::id_pad_r2].key, m_cfg_entries[button_ids::id_pad_lstick_left].key, m_cfg_entries[button_ids::id_pad_lstick_right].key, m_cfg_entries[button_ids::id_pad_lstick_down].key, m_cfg_entries[button_ids::id_pad_lstick_up].key, @@ -443,7 +443,7 @@ void pad_settings_dialog::InitButtons() void pad_settings_dialog::SetPadData(u32 large_motor, u32 small_motor) { - QColor led_color(m_handler_cfg.colorR, m_handler_cfg.colorG, m_handler_cfg.colorB); + const QColor led_color(m_handler_cfg.colorR, m_handler_cfg.colorG, m_handler_cfg.colorB); m_handler->SetPadData(m_device_name, large_motor, small_motor, led_color.red(), led_color.green(), led_color.blue(), static_cast(m_handler_cfg.led_battery_indicator), m_handler_cfg.led_battery_indicator_brightness); }