Qt: Update to Qt 5.2 code base. Makes the code much simpler!

rpcs3/rpcs3qt/glviewer.cpp

@@ -1,88 +1,56 @@
 #include "glviewer.h"
 #include <QQuickWindow>
 #include <QOpenGLContext>
-#include <QSGSimpleTextureNode>
 #include <QCoreApplication>
 
-GLViewer::GLViewer(QQuickItem* parent)
+// This class hooks beforeRendering and allows us to draw a scene and reset GL state.
-	: QQuickItem(parent),
+// In future, we will likely want to manually control the update rate.
-	  m_timerID(0),
-	  m_fbo(0)
-{
-	this->setFlag(QQuickItem::ItemHasContents);
-}
 
-GLViewer::~GLViewer()
+void GLRenderer::paint() {
-{
+	// Do GL here
-	this->cleanup();
+	glViewport(0, 0, m_viewportSize.width(), m_viewportSize.height());
-}
 
-void GLViewer::timerEvent(QTimerEvent* evt)
-{
-	if (evt && evt->timerId() == m_timerID)
-		this->update();
-}
-
-QSGNode* GLViewer::updatePaintNode(QSGNode* node, UpdatePaintNodeData* data)
-{
-	QSGSimpleTextureNode* textureNode = static_cast<QSGSimpleTextureNode*>(node);
-	if (!textureNode)
-		textureNode = new QSGSimpleTextureNode();
-	// Push Qt state.
-	glPushClientAttrib(GL_CLIENT_ALL_ATTRIB_BITS);
-	glPushAttrib(GL_ALL_ATTRIB_BITS);
-	glMatrixMode(GL_TEXTURE);
-	glPushMatrix();
-	glLoadIdentity();
-	glMatrixMode(GL_PROJECTION);
-	glPushMatrix();
-	glMatrixMode(GL_MODELVIEW);
-	glPushMatrix();
-
-	glShadeModel(GL_FLAT);
-	glDisable(GL_CULL_FACE);
-	glDisable(GL_LIGHTING);
-	glDisable(GL_STENCIL_TEST);
 	glDisable(GL_DEPTH_TEST);
+
+	// Draw blue to the window to show that we work
+	glClearColor(0.2, 0, 0.8, 1);
+	glClear(GL_COLOR_BUFFER_BIT);
+
 	glEnable(GL_BLEND);
-	glBlendFunc(GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
+	glBlendFunc(GL_SRC_ALPHA, GL_ONE);
-
+	// Put the GL state back to how it was in case it makes SceneGraph angry
-	delete m_fbo;
+	((QQuickWindow*)sender())->resetOpenGLState();
-	m_fbo = 0;
-	int width = this->width();
-	int height = this->height();
-	if (width && height) {
-		m_fbo = new QOpenGLFramebufferObject(width, height);
-		textureNode->setTexture(this->window()->createTextureFromId(m_fbo->texture(), m_fbo->size()));
 }
-	else
+
+GLViewer::GLViewer()
+	: m_renderer(0)
 {
-		textureNode->setTexture(this->window()->createTextureFromId(0, QSize(0,0)));
+	connect(this, SIGNAL(windowChanged(QQuickWindow*)), this, SLOT(handleWindowChanged(QQuickWindow*)));
 }
-	textureNode->setRect(this->boundingRect());
 
-	if (m_fbo) {
+void GLViewer::handleWindowChanged(QQuickWindow *win)
-		m_fbo->bind();
+{
+	if (win) {
+		connect(win, SIGNAL(beforeSynchronizing()), this, SLOT(sync()), Qt::DirectConnection);
+		connect(win, SIGNAL(sceneGraphInvalidated()), this, SLOT(cleanup()), Qt::DirectConnection);
+		// We will take over from here
+		win->setClearBeforeRendering(false);
+	}
 }
-	// Restore (pop) Qt state.
-	glMatrixMode(GL_TEXTURE);
-	glPopMatrix();
-	glMatrixMode(GL_PROJECTION);
-	glPopMatrix();
-	glMatrixMode(GL_MODELVIEW);
-	glPopMatrix();
-	glPopAttrib();
-	glPopClientAttrib();
 
-	if (!m_timerID)
+void GLViewer::sync()
-		m_timerID = this->startTimer(16);
+{
-
+	if (!m_renderer) {
-	return textureNode;
+		m_renderer = new GLRenderer();
+		connect(window(), SIGNAL(beforeRendering()), m_renderer, SLOT(paint()), Qt::DirectConnection);
+	}
+	m_renderer->setViewportSize(window()->size() * window()->devicePixelRatio());
 }
 
 void GLViewer::cleanup() {
-	this->killTimer(m_timerID);
+	if (m_renderer) {
-	m_timerID = 0;
+		delete m_renderer;
-	delete m_fbo;
+		m_renderer = 0;
-	m_fbo = nullptr;
 	}
+}
+

rpcs3/rpcs3qt/glviewer.h

@@ -1,23 +1,35 @@
 #pragma once
 
 #include <QQuickItem>
-#include <QOpenGLFramebufferObject>
+
+class GLRenderer : public QObject {
+    Q_OBJECT
+public:
+    GLRenderer() { }
+
+    void setViewportSize(const QSize &size) { m_viewportSize = size; }
+
+public slots:
+    void paint();
+
+private:
+    QSize m_viewportSize;
+};
 
 class GLViewer : public QQuickItem
 {
 	Q_OBJECT
 public:
-    GLViewer(QQuickItem* parent = 0);
+	GLViewer();
-    virtual ~GLViewer();
+	~GLViewer() { cleanup(); }
 
-protected:
+public slots:
-    QSGNode* updatePaintNode(QSGNode* old, UpdatePaintNodeData* data);
+	void sync();
-    void timerEvent(QTimerEvent* evt);
-
-private slots:
 	void cleanup();
 
+private slots:
+	void handleWindowChanged(QQuickWindow *win);
+
 private:
-    int m_timerID;
+	GLRenderer *m_renderer;
-    QOpenGLFramebufferObject* m_fbo;
 };

rpcs3/rpcs3qt/main.cpp

@@ -1,4 +1,4 @@
-// Qt5.1+ frontend implementation for rpcs3. Known to work on Windows, Linux, Mac
+// Qt5.2+ frontend implementation for rpcs3. Known to work on Windows, Linux, Mac
 // by Sacha Refshauge
 #include <QGuiApplication>
 #include <QQmlApplicationEngine>

rpcs3/rpcs3qt/qml/main.qml

@@ -1,6 +1,6 @@
-import QtQuick 2.1
+import QtQuick 2.2
-import QtQuick.Controls 1.0
+import QtQuick.Controls 1.1
-import QtQuick.Window 2.0
+import QtQuick.Window 2.1
 import GLViewer 1.0
 
 ApplicationWindow {
@@ -44,8 +44,7 @@ ApplicationWindow {
 			MenuItem { text: qsTr("&About...") }
 		}
 	}
-	GLViewer {
+	GLViewer {}
-		anchors.fill: parent
 	Rectangle {
 		color: Qt.rgba(0, 0.5, 0.35);
 		height: Math.round(parent.height / 2)
@@ -58,5 +57,5 @@ ApplicationWindow {
 			text: "Qt"
 		}
 	}
-	}
+
 }