archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-12 09:48:37 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

more cleanup

Browse source
This commit is contained in:
trigger 2025-04-30 00:00:27 -07:00
parent c0f312af84
commit a7913ab38a
4 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rpcs3/rpcs3qt/cheat_manager.cpp
View file

@ -851,7 +851,7 @@ cheat_manager_dialog::cheat_manager_dialog(QWidget* parent)
update_cheat_list();
});
connect(show_in_mem_viewer, &QAction::triggered, [offset]()
connect(show_in_mem_viewer, &QAction::triggered, this, [offset]()
{
memory_viewer_panel::ShowAtPC(offset);
});

2
rpcs3/rpcs3qt/hex_validator.h
View file

@ -84,7 +84,7 @@ inline bool parse_hex_qstring(const QString& input, quint64* result, int max_bit
bool ok = false;
const quint64 value = norm.toULongLong(&ok, 16);
if (ok)
if (ok && result)
*result = static_cast<u64>(value);
return ok;

4
rpcs3/rpcs3qt/log_frame.cpp
View file

@ -253,9 +253,9 @@ void log_frame::CreateAndConnectActions()
});
m_perform_show_in_mem_viewer = new QAction(tr("Show in Memory Viewer"), this);
connect(m_perform_show_in_mem_viewer, &QAction::triggered, [this]()
connect(m_perform_show_in_mem_viewer, &QAction::triggered, this, [this]()
{
QPlainTextEdit* pte = (m_tabWidget->currentIndex() == 1 ? m_tty : m_log);
const QPlainTextEdit* pte = (m_tabWidget->currentIndex() == 1 ? m_tty : m_log);
const QString selected = pte->textCursor().selectedText();
quint64 pc = 0;
if (!parse_hex_qstring(selected, &pc))

5
rpcs3/rpcs3qt/memory_viewer_panel.cpp
View file

@ -28,9 +28,6 @@
LOG_CHANNEL(gui_log, "GUI");
class CPUDisAsm;
std::shared_ptr<CPUDisAsm> make_basic_ppu_disasm();
constexpr auto qstr = QString::fromStdString;
memory_viewer_panel::memory_viewer_panel(QWidget* parent, std::shared_ptr<CPUDisAsm> disasm, u32 addr, std::function<cpu_thread*()> func)
@ -1255,7 +1252,7 @@ void memory_viewer_panel::ShowAtPC(u32 pc)
if (!handle_ptr)
{
idm::make<memory_viewer_handle>(nullptr, make_basic_ppu_disasm(), pc);
idm::make<memory_viewer_handle>(nullptr, nullptr, pc);
return;
}