archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-09 08:21:29 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimize AddGamesFromDir a bit

Browse source
This commit is contained in:
Eladash 2023-04-21 10:36:44 +03:00 • committed by Megamouse
parent 76a36f45bf
commit a1741f21cc
2 changed files with 12 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

33
rpcs3/Emu/System.cpp
View file

@ -1572,7 +1572,13 @@ game_boot_result Emulator::Load(const std::string& title_id, bool add_only, bool
fs::pending_file temp(fs::get_config_dir() + "/games.yml"); fs::pending_file temp(fs::get_config_dir() + "/games.yml");
// Do not update games.yml when TITLE_ID is empty // Do not update games.yml when TITLE_ID is empty
return temp.file && temp.file.write(out.c_str(), out.size()), temp.commit(); if (temp.file && temp.file.write(out.c_str(), out.size()), temp.commit())
{
m_games_yml_invalidated = true;
return true;
}
return false;
}; };
// Check /dev_bdvd/ // Check /dev_bdvd/
@ -3149,27 +3155,14 @@ void Emulator::AddGamesFromDir(const std::string& path)
if (!IsStopped()) if (!IsStopped())
return; return;
const std::string games_yml = fs::get_cache_dir() + "/games.yml"; m_games_yml_invalidated = false;
std::string content_before, content_after;
if (fs::file fd{games_yml})
{
content_before = fd.to_string();
}
// search dropped path first or else the direct parent to an elf is wrongly skipped // search dropped path first or else the direct parent to an elf is wrongly skipped
if (const auto error = BootGame(path, "", false, true); error == game_boot_result::no_errors) if (const auto error = BootGame(path, "", false, true); error == game_boot_result::no_errors)
{ {
if (fs::file fd{games_yml, fs::read + fs::isfile}) if (std::exchange(m_games_yml_invalidated, false))
{
content_after = fd.to_string();
}
if (content_before != content_after)
{ {
sys_log.notice("Registered game directory: %s", path); sys_log.notice("Registered game directory: %s", path);
content_before = content_after;
} }
} }
@ -3185,15 +3178,9 @@ void Emulator::AddGamesFromDir(const std::string& path)
if (const auto error = BootGame(dir_path, "", false, true); error == game_boot_result::no_errors) if (const auto error = BootGame(dir_path, "", false, true); error == game_boot_result::no_errors)
{ {
if (fs::file fd{games_yml, fs::read + fs::isfile}) if (std::exchange(m_games_yml_invalidated, false))
{
content_after = fd.to_string();
}
if (content_before != content_after)
{ {
sys_log.notice("Registered game directory: %s", dir_path); sys_log.notice("Registered game directory: %s", dir_path);
content_before = content_after;
} }
} }
} }

2
rpcs3/Emu/System.h
View file

@ -119,6 +119,8 @@ class Emulator final
atomic_t<u64> m_pause_amend_time{0}; // increased when resumed atomic_t<u64> m_pause_amend_time{0}; // increased when resumed
atomic_t<u64> m_stop_ctr{0}; // Increments when emulation is stopped atomic_t<u64> m_stop_ctr{0}; // Increments when emulation is stopped
bool m_games_yml_invalidated = false;
video_renderer m_default_renderer; video_renderer m_default_renderer;
std::string m_default_graphics_adapter; std::string m_default_graphics_adapter;