archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-12 01:38:37 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add -Werror=missing-noreturn (GCC, clang)

Browse source 
May be useful to diagnose functions which fail assertions unconditionally.
This commit is contained in:
Nekotekina 2021-04-08 00:52:18 +03:00
parent 94c62b1eec
commit 95725bf7fc
20 changed files with 55 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Utilities/Config.cpp
View file

@ -35,12 +35,14 @@ namespace cfg
bool _base::from_string(const std::string&, bool)
{
fmt::throw_exception("from_string() purecall");
cfg_log.fatal("cfg::_base::from_string() purecall");
return false;
}
bool _base::from_list(std::vector<std::string>&&)
{
fmt::throw_exception("from_list() purecall");
cfg_log.fatal("cfg::_base::from_list() purecall");
return false;
}
// Emit YAML

2
Utilities/File.cpp
View file

@ -230,7 +230,7 @@ namespace fs
{
}
stat_t file_base::stat()
[[noreturn]] stat_t file_base::stat()
{
fmt::throw_exception("fs::file::stat() not supported.");
}

2
Utilities/File.h
View file

@ -81,7 +81,7 @@ namespace fs
{
virtual ~file_base();
virtual stat_t stat();
[[noreturn]] virtual stat_t stat();
virtual void sync();
virtual bool trunc(u64 length) = 0;
virtual u64 read(void* buffer, u64 size) = 0;

1
Utilities/JIT.cpp
View file

@ -289,6 +289,7 @@ asmjit::Runtime& asmjit::get_global_runtime()
#pragma GCC diagnostic ignored "-Wstrict-aliasing"
#pragma GCC diagnostic ignored "-Wredundant-decls"
#pragma GCC diagnostic ignored "-Weffc++"
#pragma GCC diagnostic ignored "-Wmissing-noreturn"
#endif
#include "llvm/Support/TargetSelect.h"
#include "llvm/Support/FormattedStream.h"

1
Utilities/JIT.h
View file

@ -189,6 +189,7 @@ inline FT build_function_asm(F&& builder)
#pragma GCC diagnostic ignored "-Wunused-parameter"
#pragma GCC diagnostic ignored "-Wstrict-aliasing"
#pragma GCC diagnostic ignored "-Weffc++"
#pragma GCC diagnostic ignored "-Wmissing-noreturn"
#ifdef __clang__
#pragma clang diagnostic ignored "-Winconsistent-missing-override"
#endif