archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-10 00:41:26 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

SPU MFC: avoid copying of the lockline onto the stack in putllc/putlluc (#5392)

Browse source
This commit is contained in:
elad 2018-12-04 20:09:55 +02:00 • committed by Ivan
parent 45942c4962
commit 90265edfcd
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
rpcs3/Emu/Cell/SPUThread.cpp
View file

@ -1021,8 +1021,7 @@ void spu_thread::do_putlluc(const spu_mfc_cmd& args)
raddr = 0; raddr = 0;
} }
auto& data = vm::_ref<decltype(rdata)>(addr); const auto& to_write = _ref<decltype(rdata)>(args.lsa & 0x3ff80);
const auto to_write = _ref<decltype(rdata)>(args.lsa & 0x3ff80);
// Store unconditionally // Store unconditionally
if (LIKELY(g_use_rtm)) if (LIKELY(g_use_rtm))
@ -1042,6 +1041,7 @@ void spu_thread::do_putlluc(const spu_mfc_cmd& args)
} }
else else
{ {
auto& data = vm::_ref<decltype(rdata)>(addr);
auto& res = vm::reservation_lock(addr, 128); auto& res = vm::reservation_lock(addr, 128);
vm::_ref<atomic_t<u32>>(addr) += 0; vm::_ref<atomic_t<u32>>(addr) += 0;
@ -1281,13 +1281,13 @@ bool spu_thread::process_mfc_cmd(spu_mfc_cmd args)
{ {
// Store conditionally // Store conditionally
const u32 addr = args.eal & -128u; const u32 addr = args.eal & -128u;
auto& data = vm::_ref<decltype(rdata)>(addr);
const auto to_write = _ref<decltype(rdata)>(args.lsa & 0x3ff80);
bool result = false; bool result = false;
if (raddr == addr && rtime == vm::reservation_acquire(raddr, 128)) if (raddr == addr && rtime == vm::reservation_acquire(raddr, 128))
{ {
const auto& to_write = _ref<decltype(rdata)>(args.lsa & 0x3ff80);
if (LIKELY(g_use_rtm)) if (LIKELY(g_use_rtm))
{ {
if (spu_putllc_tx(raddr, rtime, rdata.data(), to_write.data())) if (spu_putllc_tx(raddr, rtime, rdata.data(), to_write.data()))
@ -1298,7 +1298,7 @@ bool spu_thread::process_mfc_cmd(spu_mfc_cmd args)
// Don't fallback to heavyweight lock, just give up // Don't fallback to heavyweight lock, just give up
} }
else if (rdata == data) else if (auto& data = vm::_ref<decltype(rdata)>(addr); rdata == data)
{ {
auto& res = vm::reservation_lock(raddr, 128); auto& res = vm::reservation_lock(raddr, 128);