archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-06 23:11:25 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Debugger: Optimize cpu_thread::dump_regs()

Browse source 
Reuse string buffer. Copies and reallocations are expensive with such large strings.
This commit is contained in:
Eladash 2022-06-22 12:00:06 +03:00 • committed by Megamouse
parent 794cbd8708
commit 5e01ffdfd8
12 changed files with 35 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

6
rpcs3/Emu/Cell/SPUThread.cpp
View file

@ -1030,10 +1030,8 @@ spu_imm_table_t::spu_imm_table_t()
}
}
std::string spu_thread::dump_regs() const
void spu_thread::dump_regs(std::string& ret) const
{
std::string ret;
const bool floats_only = debugger_float_mode.load();
SPUDisAsm dis_asm(cpu_disasm_mode::normal, ls);
@ -1148,8 +1146,6 @@ std::string spu_thread::dump_regs() const
fmt::append(ret, "[0x%02x] %08x %08x %08x %08x\n", i * sizeof(data[0])
, data[i + 0], data[i + 1], data[i + 2], data[i + 3]);
}
return ret;
}
std::string spu_thread::dump_callstack() const