archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-11 01:08:39 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

rsx: Avoid using push_back/emplace_back on empty STL containers

Browse source 
- Reckless management of STL containers causes significant slowdown
- Also reorders vertex compare steps to fail quickly on simpler checks
This commit is contained in:
kd-11 2017-06-27 20:46:36 +03:00
parent 9cb58a47cd
commit 459a7ba5a2
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
rpcs3/Emu/RSX/Common/ProgramStateCache.cpp
View file

@ -26,9 +26,11 @@ bool vertex_program_compare::operator()(const RSXVertexProgram &binary1, const R
{ {
if (binary1.output_mask != binary2.output_mask) if (binary1.output_mask != binary2.output_mask)
return false; return false;
if (binary1.data.size() != binary2.data.size())
return false;
if (binary1.rsx_vertex_inputs != binary2.rsx_vertex_inputs) if (binary1.rsx_vertex_inputs != binary2.rsx_vertex_inputs)
return false; return false;
if (binary1.data.size() != binary2.data.size()) return false;
const qword *instBuffer1 = (const qword*)binary1.data.data(); const qword *instBuffer1 = (const qword*)binary1.data.data();
const qword *instBuffer2 = (const qword*)binary2.data.data(); const qword *instBuffer2 = (const qword*)binary2.data.data();
size_t instIndex = 0; size_t instIndex = 0;
@ -40,6 +42,7 @@ bool vertex_program_compare::operator()(const RSXVertexProgram &binary1, const R
return false; return false;
instIndex++; instIndex++;
} }
return true; return true;
} }
@ -109,6 +112,7 @@ bool fragment_program_compare::operator()(const RSXFragmentProgram& binary1, con
binary1.front_back_color_enabled != binary2.front_back_color_enabled || binary1.alpha_func != binary2.alpha_func || binary1.front_back_color_enabled != binary2.front_back_color_enabled || binary1.alpha_func != binary2.alpha_func ||
binary1.shadow_textures != binary2.shadow_textures || binary1.redirected_textures != binary2.redirected_textures) binary1.shadow_textures != binary2.shadow_textures || binary1.redirected_textures != binary2.redirected_textures)
return false; return false;
const qword *instBuffer1 = (const qword*)binary1.addr; const qword *instBuffer1 = (const qword*)binary1.addr;
const qword *instBuffer2 = (const qword*)binary2.addr; const qword *instBuffer2 = (const qword*)binary2.addr;
size_t instIndex = 0; size_t instIndex = 0;
@ -119,6 +123,7 @@ bool fragment_program_compare::operator()(const RSXFragmentProgram& binary1, con
if (inst1.dword[0] != inst2.dword[0] || inst1.dword[1] != inst2.dword[1]) if (inst1.dword[0] != inst2.dword[0] || inst1.dword[1] != inst2.dword[1])
return false; return false;
instIndex++; instIndex++;
// Skip constants // Skip constants
if (fragment_program_utils::is_constant(inst1.word[1]) || if (fragment_program_utils::is_constant(inst1.word[1]) ||

5
rpcs3/Emu/RSX/RSXThread.cpp
View file

@ -273,7 +273,7 @@ namespace rsx
void thread::begin() void thread::begin()
{ {
rsx::method_registers.current_draw_clause.inline_vertex_array.clear(); rsx::method_registers.current_draw_clause.inline_vertex_array.resize(0);
in_begin_end = true; in_begin_end = true;
} }
@ -865,6 +865,7 @@ namespace rsx
RSXVertexProgram result = {}; RSXVertexProgram result = {};
const u32 transform_program_start = rsx::method_registers.transform_program_start(); const u32 transform_program_start = rsx::method_registers.transform_program_start();
result.data.reserve((512 - transform_program_start) * 4); result.data.reserve((512 - transform_program_start) * 4);
result.rsx_vertex_inputs.reserve(rsx::limits::vertex_count);
for (int i = transform_program_start; i < 512; ++i) for (int i = transform_program_start; i < 512; ++i)
{ {
@ -881,7 +882,7 @@ namespace rsx
const u32 input_mask = rsx::method_registers.vertex_attrib_input_mask(); const u32 input_mask = rsx::method_registers.vertex_attrib_input_mask();
const u32 modulo_mask = rsx::method_registers.frequency_divider_operation_mask(); const u32 modulo_mask = rsx::method_registers.frequency_divider_operation_mask();
result.rsx_vertex_inputs.clear();
for (u8 index = 0; index < rsx::limits::vertex_count; ++index) for (u8 index = 0; index < rsx::limits::vertex_count; ++index)
{ {
bool enabled = !!(input_mask & (1 << index)); bool enabled = !!(input_mask & (1 << index));