archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-11 01:08:39 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

rsx: Lower performance warnings to 'warn' level instead of 'error' level to avoid causing panic for users

Browse source
This commit is contained in:
kd-11 2022-02-07 00:29:23 +03:00 • committed by kd-11
parent 247759b75b
commit 2d9f21a2ea
5 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rpcs3/Emu/RSX/Common/surface_store.h
View file

@ -772,7 +772,7 @@ namespace rsx
if (!valid) if (!valid)
{ {
rsx_log.error("Stale surface at address 0x%x will be deleted", it->base_address); rsx_log.warning("Stale surface at address 0x%x will be deleted", it->base_address);
invalidate_surface_address(it->base_address, it->is_depth); invalidate_surface_address(it->base_address, it->is_depth);
} }
} }

2
rpcs3/Emu/RSX/Common/texture_cache.h
View file

@ -1928,7 +1928,7 @@ namespace rsx
if (const auto coverage_ratio = (coverage_size * 100ull) / memory_range.length(); if (const auto coverage_ratio = (coverage_size * 100ull) / memory_range.length();
coverage_ratio > max_overdraw_ratio) coverage_ratio > max_overdraw_ratio)
{ {
rsx_log.error("[Performance warning] Texture gather routine encountered too many objects! Operation=%d, Mipmaps=%d, Depth=%d, Sections=%zu, Ratio=%llu%", rsx_log.warning("[Performance warning] Texture gather routine encountered too many objects! Operation=%d, Mipmaps=%d, Depth=%d, Sections=%zu, Ratio=%llu%",
static_cast<int>(result.external_subresource_desc.op), attr.mipmaps, attr.depth, overlapping_fbos.size(), coverage_ratio); static_cast<int>(result.external_subresource_desc.op), attr.mipmaps, attr.depth, overlapping_fbos.size(), coverage_ratio);
m_rtts.check_for_duplicates(overlapping_fbos, memory_range); m_rtts.check_for_duplicates(overlapping_fbos, memory_range);
} }

2
rpcs3/Emu/RSX/VK/VKDraw.cpp
View file

@ -786,7 +786,7 @@ void VKGSRender::emit_geometry(u32 sub_index)
if (occlusion_id == umax) if (occlusion_id == umax)
{ {
// Force flush // Force flush
rsx_log.error("[Performance Warning] Out of free occlusion slots. Forcing hard sync."); rsx_log.warning("[Performance Warning] Out of free occlusion slots. Forcing hard sync.");
ZCULL_control::sync(this); ZCULL_control::sync(this);
occlusion_id = m_occlusion_query_manager->allocate_query(*m_current_command_buffer); occlusion_id = m_occlusion_query_manager->allocate_query(*m_current_command_buffer);

2
rpcs3/Emu/RSX/VK/VKGSRender.cpp
View file

@ -2473,7 +2473,7 @@ void VKGSRender::get_occlusion_query_result(rsx::reports::occlusion_query_info*
m_flush_requests.clear_pending_flag(); m_flush_requests.clear_pending_flag();
} }
rsx_log.error("[Performance warning] Unexpected ZCULL read caused a hard sync"); rsx_log.warning("[Performance warning] Unexpected ZCULL read caused a hard sync");
busy_wait(); busy_wait();
} }

4
rpcs3/Emu/RSX/VK/VKTexture.cpp
View file

@ -303,7 +303,7 @@ namespace vk
{ {
if (src->format_class() == dst->format_class()) if (src->format_class() == dst->format_class())
{ {
rsx_log.error("[Performance warning] Image copy requested incorrectly for matching formats."); rsx_log.warning("[Performance warning] Image copy requested incorrectly for matching formats.");
copy_image(cmd, src, dst, src_rect, dst_rect, mipmaps, src_transfer_mask, dst_transfer_mask); copy_image(cmd, src, dst, src_rect, dst_rect, mipmaps, src_transfer_mask, dst_transfer_mask);
return; return;
} }
@ -417,7 +417,7 @@ namespace vk
src->format() != dst->format()) src->format() != dst->format())
{ {
// Copying between two depth formats must match exactly or crashes will happen // Copying between two depth formats must match exactly or crashes will happen
rsx_log.error("[Performance warning] Image copy was requested incorrectly for mismatched depth formats"); rsx_log.warning("[Performance warning] Image copy was requested incorrectly for mismatched depth formats");
copy_image_typeless(cmd, src, dst, src_rect, dst_rect, mipmaps); copy_image_typeless(cmd, src, dst, src_rect, dst_rect, mipmaps);
return; return;
} }