From 21cdbd90e9a171987c9b7efef0ae1f71a77caae8 Mon Sep 17 00:00:00 2001
From: Megamouse <studienricky89@googlemail.com>
Date: Thu, 8 May 2025 14:54:54 +0200
Subject: [PATCH] trophies/overlays: treat unlocked hidden trophies just like
 normal unlocked trophies

---
 .../Overlays/Trophies/overlay_trophy_list_dialog.cpp   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/rpcs3/Emu/RSX/Overlays/Trophies/overlay_trophy_list_dialog.cpp b/rpcs3/Emu/RSX/Overlays/Trophies/overlay_trophy_list_dialog.cpp
index bd8acd8446..13db1dff1e 100644
--- a/rpcs3/Emu/RSX/Overlays/Trophies/overlay_trophy_list_dialog.cpp
+++ b/rpcs3/Emu/RSX/Overlays/Trophies/overlay_trophy_list_dialog.cpp
@@ -31,7 +31,7 @@ namespace rsx
 
 			if (fs::exists(icon_path))
 			{
-				icon_data = std::make_unique<image_info>(icon_path, details.hidden || locked);
+				icon_data = std::make_unique<image_info>(icon_path, locked);
 				static_cast<image_view*>(image.get())->set_raw_image(icon_data.get());
 			}
 			else
@@ -53,7 +53,7 @@ namespace rsx
 
 			std::unique_ptr<overlay_element> text_stack  = std::make_unique<vertical_layout>();
 			std::unique_ptr<overlay_element> padding     = std::make_unique<spacer>();
-			std::unique_ptr<overlay_element> header_text = std::make_unique<label>(fmt::format("%s (%s%s)", (locked && !details.hidden) ? get_localized_string(localized_string_id::HOME_MENU_TROPHY_LOCKED_TITLE, details.name) : details.name, trophy_type, platinum_relevant ? " - " + get_localized_string(localized_string_id::HOME_MENU_TROPHY_PLATINUM_RELEVANT) : ""));
+			std::unique_ptr<overlay_element> header_text = std::make_unique<label>(fmt::format("%s (%s%s)", locked ? get_localized_string(localized_string_id::HOME_MENU_TROPHY_LOCKED_TITLE, details.name) : details.name, trophy_type, platinum_relevant ? " - " + get_localized_string(localized_string_id::HOME_MENU_TROPHY_PLATINUM_RELEVANT) : ""));
 			std::unique_ptr<overlay_element> subtext     = std::make_unique<label>(details.description);
 
 			padding->set_size(1, 1);
@@ -344,7 +344,8 @@ namespace rsx
 				details.trophyId = atoi(n->GetAttribute("id").c_str());
 				details.hidden = n->GetAttribute("hidden")[0] == 'y';
 
-				const bool hide_trophy = details.hidden && !m_show_hidden_trophies;
+				const bool unlocked = m_trophy_data->trop_usr->GetTrophyUnlockState(details.trophyId);
+				const bool hide_trophy = details.hidden && !unlocked && !m_show_hidden_trophies;
 
 				if (details.trophyId == old_trophy_id)
 				{
@@ -373,7 +374,7 @@ namespace rsx
 				}
 
 				// Get name and detail
-				if (details.hidden)
+				if (details.hidden && !unlocked)
 				{
 					strcpy_trunc(details.name, hidden_title);
 					strcpy_trunc(details.description, hidden_description);
@@ -394,7 +395,6 @@ namespace rsx
 					}
 				}
 
-				const bool unlocked = m_trophy_data->trop_usr->GetTrophyUnlockState(details.trophyId);
 				const auto icon_path_it = m_trophy_data->trophy_image_paths.find(details.trophyId);
 
 				std::unique_ptr<overlay_element> entry = std::make_unique<trophy_list_entry>(details, icon_path_it != m_trophy_data->trophy_image_paths.cend() ? icon_path_it->second : "", !unlocked, platinum_relevant);