archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-09 16:31:28 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update settings to indicate speed differences between Interpreters and Recompilers for less confusion (#4345)

Browse source 
* Update settings_dialog.ui

* Qt: completely detach ppu and spu ui texts from backend.
This commit is contained in:
Asinine 2018-03-27 16:55:54 +00:00 • committed by Ani
parent a36acf49d8
commit 2172e61ce5
2 changed files with 8 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

16
rpcs3/rpcs3qt/settings_dialog.cpp
View file

@ -159,20 +159,11 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> guiSettings, std:
for (int i = 0; i < ppu_list.count(); i++) for (int i = 0; i < ppu_list.count(); i++)
{ {
ppuBG->button(i)->setText(ppu_list[i]);
if (ppu_list[i] == selectedPPU) if (ppu_list[i] == selectedPPU)
{ {
ppuBG->button(i)->setChecked(true); ppuBG->button(i)->setChecked(true);
} }
#ifndef LLVM_AVAILABLE
if (ppu_list[i].toLower().contains("llvm"))
{
ppuBG->button(i)->setEnabled(false);
}
#endif
connect(ppuBG->button(i), &QAbstractButton::pressed, [=]() connect(ppuBG->button(i), &QAbstractButton::pressed, [=]()
{ {
xemu_settings->SetSetting(emu_settings::PPUDecoder, sstr(ppu_list[i])); xemu_settings->SetSetting(emu_settings::PPUDecoder, sstr(ppu_list[i]));
@ -198,8 +189,6 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> guiSettings, std:
for (int i = 0; i < spu_list.count(); i++) for (int i = 0; i < spu_list.count(); i++)
{ {
spuBG->button(i)->setText(spu_list[i]);
if (spu_list[i] == selectedSPU) if (spu_list[i] == selectedSPU)
{ {
spuBG->button(i)->setChecked(true); spuBG->button(i)->setChecked(true);
@ -212,6 +201,11 @@ settings_dialog::settings_dialog(std::shared_ptr<gui_settings> guiSettings, std:
} }
} }
#ifndef LLVM_AVAILABLE
ui->ppu_llvm->setEnabled(false);
ui->spu_llvm->setEnabled(false);
#endif
// lib options tool tips // lib options tool tips
SubscribeTooltip(ui->lib_auto, json_cpu_lib["auto"].toString()); SubscribeTooltip(ui->lib_auto, json_cpu_lib["auto"].toString());
SubscribeTooltip(ui->lib_manu, json_cpu_lib["manual"].toString()); SubscribeTooltip(ui->lib_manu, json_cpu_lib["manual"].toString());

6
rpcs3/rpcs3qt/settings_dialog.ui
View file

@ -70,7 +70,7 @@
<item> <item>
<widget class="QRadioButton" name="ppu_llvm"> <widget class="QRadioButton" name="ppu_llvm">
<property name="text"> <property name="text">
<string>Recompiler (LLVM)</string> <string>LLVM Recompiler (fastest)</string>
</property> </property>
</widget> </widget>
</item> </item>
@ -100,7 +100,7 @@
<item> <item>
<widget class="QRadioButton" name="spu_asmjit"> <widget class="QRadioButton" name="spu_asmjit">
<property name="text"> <property name="text">
<string>Recompiler (ASMJIT)</string> <string>ASMJIT Recompiler (fastest)</string>
</property> </property>
</widget> </widget>
</item> </item>
@ -110,7 +110,7 @@
<bool>false</bool> <bool>false</bool>
</property> </property>
<property name="text"> <property name="text">
<string>Recompiler (LLVM)</string> <string>LLVM Recompiler</string>
</property> </property>
</widget> </widget>
</item> </item>