From 106f31db6a1ba490cef049b10228261874d2af63 Mon Sep 17 00:00:00 2001 From: Elad Ashkenazi Date: Wed, 26 Jul 2023 16:28:09 +0300 Subject: [PATCH] sceNpTrophy: Minor UB fixup id.data[9] is char while isprint should accept u8. --- rpcs3/Emu/Cell/Modules/sceNpTrophy.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rpcs3/Emu/Cell/Modules/sceNpTrophy.cpp b/rpcs3/Emu/Cell/Modules/sceNpTrophy.cpp index 1880d2beff..8852df6955 100644 --- a/rpcs3/Emu/Cell/Modules/sceNpTrophy.cpp +++ b/rpcs3/Emu/Cell/Modules/sceNpTrophy.cpp @@ -249,7 +249,8 @@ void fmt_class_string::format(std::string& out, u64 arg) { const auto& id = get_object(arg); - fmt::append(out, "{ data='%s', term='%s' (0x%x), num=%d, dummy=%d }", id.data, std::isprint(id.data[9]) ? fmt::format("%c", id.data[9]) : "", id.data[9], id.num, id.dummy); + const u8 term = id.data[9]; + fmt::append(out, "{ data='%s', term='%s' (0x%x), num=%d, dummy=%d }", id.data, std::isprint(term) ? fmt::format("%c", term) : "", term, id.num, id.dummy); } // Helpers