From 09ab5477e881b0592f336122799165e52bd03157 Mon Sep 17 00:00:00 2001 From: Megamouse Date: Sat, 24 May 2025 04:45:54 +0200 Subject: [PATCH] rsx: use more const ref --- rpcs3/Emu/RSX/GL/GLDraw.cpp | 8 ++++---- rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp | 6 +++--- rpcs3/Emu/RSX/GL/GLGSRender.cpp | 2 +- rpcs3/Emu/RSX/GL/GLTexture.cpp | 2 +- rpcs3/Emu/RSX/VK/VKGSRender.cpp | 2 +- rpcs3/Emu/RSX/VK/VKResourceManager.cpp | 2 +- rpcs3/Emu/RSX/VK/vkutils/image.cpp | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/rpcs3/Emu/RSX/GL/GLDraw.cpp b/rpcs3/Emu/RSX/GL/GLDraw.cpp index 1a0515ef48..955bfbd59b 100644 --- a/rpcs3/Emu/RSX/GL/GLDraw.cpp +++ b/rpcs3/Emu/RSX/GL/GLDraw.cpp @@ -569,7 +569,7 @@ void GLGSRender::emit_geometry(u32 sub_index) if (vertex_state && !m_vertex_layout.validate()) { // No vertex inputs enabled - // Execute remainining pipeline barriers with NOP draw + // Execute remaining pipeline barriers with NOP draw do { draw_call.execute_pipeline_dependencies(m_ctx); @@ -619,9 +619,9 @@ void GLGSRender::emit_geometry(u32 sub_index) } else { - const auto subranges = draw_call.get_subranges(); + const auto& subranges = draw_call.get_subranges(); const auto draw_count = subranges.size(); - const auto driver_caps = gl::get_driver_caps(); + const auto& driver_caps = gl::get_driver_caps(); bool use_draw_arrays_fallback = false; m_scratch_buffer.resize(draw_count * 24); @@ -631,7 +631,7 @@ void GLGSRender::emit_geometry(u32 sub_index) u32 first = 0; u32 dst_index = 0; - for (const auto &range : subranges) + for (const auto& range : subranges) { firsts[dst_index] = first; counts[dst_index] = range.count; diff --git a/rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp b/rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp index 3f65be3bae..3c95d571d3 100644 --- a/rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp +++ b/rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp @@ -33,7 +33,7 @@ void GLFragmentDecompilerThread::insertHeader(std::stringstream & OS) if (device_props.has_native_half_support) { - const auto driver_caps = gl::get_driver_caps(); + const auto& driver_caps = gl::get_driver_caps(); if (driver_caps.NV_gpu_shader5_supported) { required_extensions.push_back("GL_NV_gpu_shader5"); @@ -47,7 +47,7 @@ void GLFragmentDecompilerThread::insertHeader(std::stringstream & OS) if (properties.multisampled_sampler_mask) { // Requires this extension or GLSL 450 - const auto driver_caps = gl::get_driver_caps(); + const auto& driver_caps = gl::get_driver_caps(); if (driver_caps.glsl_version.version >= 450) { gl_version = 450; @@ -366,7 +366,7 @@ void GLFragmentProgram::Decompile(const RSXFragmentProgram& prog) if (g_cfg.video.shader_precision == gpu_preset_level::low) { - const auto driver_caps = gl::get_driver_caps(); + const auto& driver_caps = gl::get_driver_caps(); decompiler.device_props.has_native_half_support = driver_caps.NV_gpu_shader5_supported || driver_caps.AMD_gpu_shader_half_float_supported; decompiler.device_props.has_low_precision_rounding = driver_caps.vendor_NVIDIA; } diff --git a/rpcs3/Emu/RSX/GL/GLGSRender.cpp b/rpcs3/Emu/RSX/GL/GLGSRender.cpp index 6101bd70c1..b6c27c4dd8 100644 --- a/rpcs3/Emu/RSX/GL/GLGSRender.cpp +++ b/rpcs3/Emu/RSX/GL/GLGSRender.cpp @@ -148,7 +148,7 @@ void GLGSRender::on_init_thread() rsx_log.success("GL VERSION: %s", reinterpret_cast(glGetString(GL_VERSION))); rsx_log.success("GLSL VERSION: %s", reinterpret_cast(glGetString(GL_SHADING_LANGUAGE_VERSION))); - auto& gl_caps = gl::get_driver_caps(); + const auto& gl_caps = gl::get_driver_caps(); std::vector exception_reasons; if (!gl_caps.ARB_texture_buffer_object_supported) diff --git a/rpcs3/Emu/RSX/GL/GLTexture.cpp b/rpcs3/Emu/RSX/GL/GLTexture.cpp index a0711d52d7..0c34690bf4 100644 --- a/rpcs3/Emu/RSX/GL/GLTexture.cpp +++ b/rpcs3/Emu/RSX/GL/GLTexture.cpp @@ -582,7 +582,7 @@ namespace gl const std::vector &input_layouts, bool is_swizzled, GLenum gl_format, GLenum gl_type, rsx::simple_array& staging_buffer) { - const auto driver_caps = gl::get_driver_caps(); + const auto& driver_caps = gl::get_driver_caps(); rsx::texture_uploader_capabilities caps { .supports_byteswap = true, diff --git a/rpcs3/Emu/RSX/VK/VKGSRender.cpp b/rpcs3/Emu/RSX/VK/VKGSRender.cpp index 2c7699407e..9ac52774ea 100644 --- a/rpcs3/Emu/RSX/VK/VKGSRender.cpp +++ b/rpcs3/Emu/RSX/VK/VKGSRender.cpp @@ -565,7 +565,7 @@ VKGSRender::VKGSRender(utils::serial* ar) noexcept : GSRender(ar) m_fragment_texture_params_buffer_info = { m_fragment_texture_params_ring_info.heap->value, 0, 16 }; m_raster_env_buffer_info = { m_raster_env_ring_info.heap->value, 0, 128 }; - const auto limits = m_device->gpu().get_limits(); + const auto& limits = m_device->gpu().get_limits(); m_texbuffer_view_size = std::min(limits.maxTexelBufferElements, VK_ATTRIB_RING_BUFFER_SIZE_M * 0x100000u); if (m_texbuffer_view_size < 0x800000) diff --git a/rpcs3/Emu/RSX/VK/VKResourceManager.cpp b/rpcs3/Emu/RSX/VK/VKResourceManager.cpp index 3c9eff4ef3..9d34509a09 100644 --- a/rpcs3/Emu/RSX/VK/VKResourceManager.cpp +++ b/rpcs3/Emu/RSX/VK/VKResourceManager.cpp @@ -50,7 +50,7 @@ namespace vk { // For any managed resources, try to keep the number of unused/idle resources as low as possible. // Improves search times as well as keeping us below the hardware limit. - const auto limits = get_current_renderer()->gpu().get_limits(); + const auto& limits = get_current_renderer()->gpu().get_limits(); const auto allocated_sampler_count = vmm_get_application_pool_usage(VMM_ALLOCATION_POOL_SAMPLER); const auto max_allowed_samplers = std::min((limits.maxSamplerAllocationCount * 3u) / 4u, 2048u); diff --git a/rpcs3/Emu/RSX/VK/vkutils/image.cpp b/rpcs3/Emu/RSX/VK/vkutils/image.cpp index 3146552f56..1aa90648ce 100644 --- a/rpcs3/Emu/RSX/VK/vkutils/image.cpp +++ b/rpcs3/Emu/RSX/VK/vkutils/image.cpp @@ -11,7 +11,7 @@ namespace vk { void image::validate(const vk::render_device& dev, const VkImageCreateInfo& info) const { - const auto gpu_limits = dev.gpu().get_limits(); + const auto& gpu_limits = dev.gpu().get_limits(); u32 longest_dim, dim_limit; switch (info.imageType)