archive/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-07-08 16:01:42 +12:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove comments in confirmed files.

Browse source
This commit is contained in:
luxsie 2015-04-11 13:31:28 +08:00
parent 94441d7df3
commit 02c263fc19
5 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
rpcs3/Emu/FS/vfsStreamMemory.cpp
View file

@ -38,7 +38,6 @@ u64 vfsStreamMemory::Write(const void* src, u64 size)
u64 vfsStreamMemory::Read(void* dst, u64 size) u64 vfsStreamMemory::Read(void* dst, u64 size)
{ {
// TODO:: Syphurith: Should us do anything? Since Asserts aren't included in Release builds.
assert(Tell() < GetSize()); assert(Tell() < GetSize());
if (Tell() + size > GetSize()) if (Tell() + size > GetSize())
{ {

3
rpcs3/Emu/RSX/RSXThread.cpp
View file

@ -200,7 +200,6 @@ u32 RSXThread::OutOfArgsCount(const uint x, const u32 cmd, const u32 count, cons
#define case_32(offset, step) \ #define case_32(offset, step) \
case_16(offset, step) \ case_16(offset, step) \
case_16(offset + 16*step, step) case_16(offset + 16*step, step)
// TODO:: Syphurith: I'm not sure about whether this is correct or missing a break;.
#define case_range(n, offset, step) \ #define case_range(n, offset, step) \
case_##n(offset, step) \ case_##n(offset, step) \
index = (cmd - offset) / step index = (cmd - offset) / step
@ -369,7 +368,6 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const
} }
// Texture // Texture
// TODO:: Syphurith: Ensure it don't need to break;? case 0: A=0; case 1: A=1; would always give you A=1.
case_range(16, NV4097_SET_TEXTURE_FORMAT, 0x20); case_range(16, NV4097_SET_TEXTURE_FORMAT, 0x20);
case_range(16, NV4097_SET_TEXTURE_OFFSET, 0x20); case_range(16, NV4097_SET_TEXTURE_OFFSET, 0x20);
case_range(16, NV4097_SET_TEXTURE_FILTER, 0x20); case_range(16, NV4097_SET_TEXTURE_FILTER, 0x20);
@ -400,7 +398,6 @@ void RSXThread::DoCmd(const u32 fcmd, const u32 cmd, const u32 args_addr, const
} }
// Vertex Texture // Vertex Texture
// TODO:: Syphurith: Ensure it don't need to break;? Similiar reason..
case_range(4, NV4097_SET_VERTEX_TEXTURE_FORMAT, 0x20); case_range(4, NV4097_SET_VERTEX_TEXTURE_FORMAT, 0x20);
case_range(4, NV4097_SET_VERTEX_TEXTURE_OFFSET, 0x20); case_range(4, NV4097_SET_VERTEX_TEXTURE_OFFSET, 0x20);
case_range(4, NV4097_SET_VERTEX_TEXTURE_FILTER, 0x20); case_range(4, NV4097_SET_VERTEX_TEXTURE_FILTER, 0x20);

1
rpcs3/Emu/SysCalls/Modules/cellCamera.h
View file

@ -314,7 +314,6 @@ struct CellCameraAttributes
u32 LED; u32 LED;
u32 AUDIOGAIN; u32 AUDIOGAIN;
u32 QS; u32 QS;
// Syphurith: Found using cppcheck. This is originally stated as an single-element array, however references its [0] and [1]. So i changed this to 2 u32 units.
u32 NONZEROCOEFFS[2]; u32 NONZEROCOEFFS[2];
u32 YUVFLAG; u32 YUVFLAG;
u32 JPEGFLAG; u32 JPEGFLAG;

2
rpcs3/Emu/SysCalls/Modules/cellSpurs.cpp
View file

@ -2206,7 +2206,6 @@ s32 cellSpursCreateTasksetWithAttribute(vm::ptr<CellSpurs> spurs, vm::ptr<CellSp
if (!attr) if (!attr)
{ {
// Syphurith: If that is intentionally done, please remove the 'return'. Or else just remove this comment.
return CELL_SPURS_TASK_ERROR_NULL_POINTER; return CELL_SPURS_TASK_ERROR_NULL_POINTER;
} }
@ -2375,7 +2374,6 @@ s32 spursCreateTask(vm::ptr<CellSpursTaskset> taskset, vm::ptr<u32> task_id, vm:
if (tmp_task_id >= CELL_SPURS_MAX_TASK) if (tmp_task_id >= CELL_SPURS_MAX_TASK)
{ {
// Syphurith: If that is intentionally done, please remove the 'return'. Or else just remove this comment.
return CELL_SPURS_TASK_ERROR_AGAIN; return CELL_SPURS_TASK_ERROR_AGAIN;
} }

3
rpcs3/Emu/SysCalls/lv2/sys_spu.cpp
View file

@ -508,8 +508,7 @@ s32 sys_spu_thread_group_terminate(u32 id, s32 value)
} }
} }
// TODO:: Syphurith: Thank @danilaml (first) and let us talk about this mistake/typo. Have you used the wrong constant for the third condition? if ((group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING))
if ((group->state <= SPU_THREAD_GROUP_STATUS_INITIALIZED) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING) || (group->state == SPU_THREAD_GROUP_STATUS_WAITING))
{ {
return CELL_EINVAL; return CELL_EINVAL;
} }