From ce86e39f4bef87d233fc39c997f1c50bd79914a1 Mon Sep 17 00:00:00 2001 From: bitscher Date: Sat, 3 Sep 2022 17:47:06 -0700 Subject: [PATCH] Fix always false comparison Other places check against 0xFF instead of 0xFF /root/cemu/src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp:245:50: warning: result of comparison of constant 65535 with expression of type 'uint8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare] if( shaderContext->paramMapping[i].exportParam == 0xFFFF ) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~ --- src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp b/src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp index 58d3b635..7df5eecd 100644 --- a/src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp +++ b/src/Cafe/HW/Latte/Core/LatteGSCopyShaderParser.cpp @@ -242,7 +242,7 @@ LatteParsedGSCopyShader* LatteGSCopyShaderParser_parse(uint8* programData, uint3 // verify if all registers are exported for(sint32 i=0; inumParam; i++) { - if( shaderContext->paramMapping[i].exportParam == 0xFFFF ) + if( shaderContext->paramMapping[i].exportParam == 0xFF ) debugBreakpoint(); } return shaderContext;